CLI (run): Only ask for stdin for -i #483
Merged
+16
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if you asked for a pty and also wanted to detach we'd open stdin and then immediately close that pipe which would close the guest relay as well. I don't believe we need stdin open unless it's asked for with -i. Truthfully there's one extra bit here that is needed which is if -i and -d are supplied we need to tell the daemon to open stdin, but not send an fd (as they're client supplied and the client/cli is going to exit immediately). That will need to be a followup, as it's mainly useful for attach which we don't have today.
jglogan
approved these changes
Aug 11, 2025
Contributor
jglogan
left a comment
jglogan
left a comment
There was a problem hiding this comment.
lgtm, but see the general comment regarding location of the ProcessIO type
|
|
||
| let stdin: Pipe? = { | ||
| if !interactive && !tty { | ||
| if !interactive { |
Contributor
There was a problem hiding this comment.
Should ProcessIO live in the CLI target, or ContainerClient, at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if you asked for a pty and also wanted to detach we'd open stdin and then immediately close that pipe which would close the guest relay as well. I don't believe we need stdin open unless it's asked for with -i. Truthfully there's one extra bit here that is needed which is if -i and -d are supplied we need to tell the daemon to open stdin, but not send an fd (as they're client supplied and the client/cli is going to exit immediately). That will need to be a followup, as it's mainly useful for attach which we don't have today.